This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Addition of en_GB mobileNumber methods #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Return a en_GB cell (mobile) phone number | ||
| * @return string | ||
| */ | ||
| public static function cellNumber() |
There was a problem hiding this comment.
Not a big fan of multiple ways to do a single thing.
There was a problem hiding this comment.
I added that in to be consistent with
/src/Faker/Provider/en_NZ/PhoneNumber.php
There was a problem hiding this comment.
Then I suggest you remove it from your locale, AND from the en_NZ. This duplicate formatter passed through my code review...
|
I've removed cellNumber from en_GB and en_NZ. |
|
Tests fail |
fzaninotto
added a commit
that referenced
this pull request
Jan 4, 2015
Addition of en_GB mobileNumber methods
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions to the PhoneNumber Provider for en_GB so that a UK format phone number can be returned.