Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fix ru_RU middle names are different for different genders #450

Merged
merged 2 commits into from
Nov 3, 2014
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions src/Faker/Provider/ru_RU/Person.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,17 @@
class Person extends \Faker\Provider\Person
{
protected static $maleNameFormats = array(
'{{firstNameMale}} {{middleName}} {{lastName}}',
'{{lastName}} {{firstNameMale}} {{middleName}}',
'{{firstNameMale}} {{middleNameMale}} {{lastName}}',
'{{lastName}} {{firstNameMale}} {{middleNameMale}}',
);

/**
* This provider uses wikipedia's 250 top russian last names
* That list of MALE last names could be safely extended to FEMALE list just by adding 'a' letter at the end
*/
protected static $femaleNameFormats = array(
'{{firstNameFemale}} {{middleName}} {{lastName}}',
'{{lastName}} {{firstNameFemale}} {{middleName}}',
'{{firstNameFemale}} {{middleNameFemale}} {{lastName}}а',
'{{lastName}}а {{firstNameFemale}} {{middleNameFemale}}',
);

/**
Expand Down Expand Up @@ -46,12 +50,18 @@ class Person extends \Faker\Provider\Person
'Эмма', 'Юлия', 'Яна', 'Ярослава',
);

protected static $middleName = array(
protected static $middleNameMale = array(
'Александрович', 'Алексеевич', 'Андреевич', 'Дмитриевич', 'Евгеньевич',
'Сергеевич', 'Иванович', 'Фёдорович', 'Львович', 'Романович', 'Владимирович',
'Борисович', 'Максимович',
);

protected static $middleNameFemale = array(
'Александровна', 'Алексеевна', 'Андреевна', 'Дмитриевна', 'Евгеньевна',
'Сергеевна', 'Ивановна', 'Фёдоровна', 'Львовна', 'Романовна', 'Владимировна',
'Борисовна', 'Максимовна',
);

/**
* {@link} http://ru.wikipedia.org/wiki/%D0%A1%D0%BF%D0%B8%D1%81%D0%BE%D0%BA_%D0%BE%D0%B1%D1%89%D0%B5%D1%80%D1%83%D1%81%D1%81%D0%BA%D0%B8%D1%85_%D1%84%D0%B0%D0%BC%D0%B8%D0%BB%D0%B8%D0%B9
**/
Expand Down Expand Up @@ -96,16 +106,30 @@ class Person extends \Faker\Provider\Person
);

/**
* Return middle name
* Return male middle name
*
* @example 'Иванович'
*
* @access public
*
* @return string Middle name
*/
public function middleName()
public function middleNameMale()
{
return static::randomElement(static::$middleNameMale);
}

/**
* Return female middle name
*
* @example 'Ивановна'
*
* @access public
*
* @return string Middle name
*/
public function middleNameFemale()
{
return static::randomElement(static::$middleName);
return static::randomElement(static::$middleNameFemale);
}
}