This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
+1 SWIFT/BIC payment type #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -280,4 +280,15 @@ protected static function addBankCodeChecksum($iban, $countryCode = '') | |||
| { | |||
| return $iban; | |||
| } | |||
|
|
|||
| /** | |||
| + * Return the String of a SWIFT/BIC number | |||
|
Great! Could you also update the README and the upper part of the Generator class (to let IDE guess the new formatter)? |
|
I should have read the CONTRIBUTING.md 👈 ... |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uppercasing Swift/Bic values seems to be common practice, even though ISO-9362 specification & the related Wikipedia Page both avoid giving particular indications on that matter.
I used the new Faker's Regex-based generator, and I presume any unit test may be useless here, since
BaseProvider::regexify()is already test-covered.