This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Created faker for Currency Codes. #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
added a commit
that referenced
this pull request
Jan 12, 2015
Created faker for Currency Codes.
|
Thanks! |
|
Thanks a lot! One thing I forgot and that was to update the realm file :) Hopefully you can update that so I don't need to create another PR. |
|
Ah, right. Can you create a small additional PR just for that? It's better if the commit has your name on it :) |
|
Sure! Besides the readme file, are there any other documentation files I need to update? Changelog for example? |
|
No, just the readme ; I'll handle the changelog. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created faker for currency codes (similar to country codes and language codes). The list of currencies are taken from the ISO 4217 standard list.