Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Russian Bank names provider #553

Merged
merged 3 commits into from
Apr 27, 2015
Merged

Russian Bank names provider #553

merged 3 commits into from
Apr 27, 2015

Conversation

wizardjedi
Copy link
Contributor

Hi, folks.

I've just implemented generator for Russian Bank names. Real bank names you can get from banki.ru (see complete list: http://www.banki.ru/banks/)

@wizardjedi
Copy link
Contributor Author

Added description to readme.md

* sed -r 's/&mdash;//' | sed -r 's/[\<\>]//g' | sed -r "s/(^|$)/'/g" | sed -r 's/$/,/' | sed -r 's/\&(laquo|raquo);/"/g' | \
* sed -r 's/\s+/ /g'"
*/
protected static $banks = array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that list would be indexed by bank code it could be used to generate an account number for a specific bank. This could be useful to verify that a bank name detection mechanism in an application works correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You absolutly right! But i've no enough information about bank codes in russia. It seems that there are multiple bank registers for banks. So it's hard to get bank id.

That's why i didn't set any ids for banks. Maybe i'll add bank codes in future.

@wizardjedi
Copy link
Contributor Author

Hi.

Any comments?

fzaninotto added a commit that referenced this pull request Apr 27, 2015
@fzaninotto fzaninotto merged commit 082c744 into fzaninotto:master Apr 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants