Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Add ar_SA locale #618

Merged
merged 5 commits into from
Aug 24, 2015
Merged

Add ar_SA locale #618

merged 5 commits into from
Aug 24, 2015

Conversation

ibrasho
Copy link
Contributor

@ibrasho ibrasho commented Jun 23, 2015

No description provided.

@fzaninotto
Copy link
Owner

Tests fail, can you check?

@fzaninotto
Copy link
Owner

Bump, I will close your PR shortly of you don't fix the tests

@ibrasho
Copy link
Contributor Author

ibrasho commented Jul 13, 2015

I just updated the entries. This should resolve the issue.

@fzaninotto
Copy link
Owner

Why did you repeat the realText() method in the Text provider?

@ibrasho
Copy link
Contributor Author

ibrasho commented Jul 13, 2015

If I don't, won't it default to faking text from the en_US locale?

@fzaninotto
Copy link
Owner

You just need to override the data in the Text provider, not the realText() method (which is inherited).

@ibrasho
Copy link
Contributor Author

ibrasho commented Aug 24, 2015

I've updated the PR and also updated the ar_JO Text provider.

fzaninotto added a commit that referenced this pull request Aug 24, 2015
@fzaninotto fzaninotto merged commit 47f3c54 into fzaninotto:master Aug 24, 2015
@fzaninotto
Copy link
Owner

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants