This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Adds time zone support for provider methods returning DateTime instance #675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are four
DateTime
returning methods:dateTime
,dateTimeAD
,dateTimeBetween
, anddateTimeInterval
, Two of these (dateTimeBetween
anddateTimeInterval
) set the timezone on the returned object, while the other two do not. This can lead to user land juggling timezones when comparing dates returned from the different generators.This PR updates these four
DateTime
returning methods to set the time zone to result ofdate_default_timezone_get
or the user-specified timezone given in the final argument to all methods. Test coverage updated to check that the default and custom time zones are handled.