This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
added PHPDocs, removed unused variable #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for feedback. I removed every @param where I couldn't safely determine the type. On the others I added a type. |
| @@ -15,11 +15,18 @@ public function __construct($default = null) | |||
| $this->default = $default; | |||
| } | |||
|
|
|||
| /** | |||
| * @param string $attribute | |||
There was a problem hiding this comment.
nah, not necessarily string. Same for __call
|
I added the two annotations. |
fzaninotto
added a commit
that referenced
this pull request
Oct 19, 2015
added PHPDocs, removed unused variable
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added some PHPDocs and removed a unused variable.
greetings,
Daniel