[FEATURE] New providers de_CH, fr_CH, it_CH #739

r3h6 · 2015-10-16T19:08:59Z

This is a very first release of providers for Switzerland.

r3h6 · 2015-10-18T10:10:54Z

Fixed the error. Now passing unit test on my local development environment.

fzaninotto · 2015-10-19T10:04:38Z

src/Faker/Provider/fr_CH/Address.php

+    protected static $postcode = array('####');
+
+    protected static $cityNames = array(
+         'Aarau', 'Aarberg', 'Aarburg', 'Agno', 'Aigle VD', 'Altdorf', 'Altstätten', 'Appenzell', 'Arbon', 'Ascona', 'Aubonne', 'Avenches', 'Baden', 'Bad Zurzach', 'Bâle', 'Bellinzone', 'Berne', 'Beromünster', 'Berthoud', 'Biasca', 'Bienne', 'Bischofszell', 'Boudry', 'Bourg-Saint-Pierre', 'Bremgarten AG', 'Brigue', 'Brugg', 'Bulle', 'Bülach', 'Cerlier', 'Châtel-Saint-Denis', 'Coire', 'Conthey', 'Coppet', 'Cossonay', 'Croglio', 'Cudrefin', 'Cully', 'Delémont', 'Diessenhofen', 'Échallens', 'Eglisau', 'Elgg', 'Estavayer-le-Lac', 'Frauenfeld', 'Fribourg', 'Genève', 'Glaris', 'Gordola', 'Grandcour', 'Grandson', 'Greifensee', 'Grüningen', 'Gruyères', 'Hermance', 'Huttwil', 'Ilanz', 'Kaiserstuhl', 'Klingnau', 'La Chaux-de-Fonds', 'La Neuveville', 'La Sarraz', 'La Tour-de-Peilz', 'La Tour-de-Trême', 'Le Landeron', 'Les Clées', 'Lachen', 'Langenthal', 'Laufon', 'Laufenburg', 'Laupen', 'Lausanne', 'Lenzburg', 'Loèche', 'Lichtensteig', 'Liestal', 'Locarno', 'Losone', 'Lugano', 'Lutry', 'Lucerne', 'Maienfeld', 'Martigny', 'Mellingen', 'Mendrisio', 'Monthey', 'Morat', 'Morcote', 'Morges', 'Moudon', 'Moutier', 'Münchenstein', 'Neuchâtel', 'Neunkirch', 'Nidau', 'Nyon', 'Olten', 'Orbe', 'Orsières', 'Payerne', 'Porrentruy', 'Rapperswil', 'Regensberg', 'Rheinau', 'Rheineck', 'Rheinfelden', 'Riva San Vitale', 'Rolle', 'Romainmôtier', 'Romont FR', 'Rorschach', 'Rue', 'Saillon', 'Saint-Maurice', 'Saint-Prex', 'Saint-Ursanne', 'Sala', 'Saint-Gall', 'Sargans', 'Sarnen', 'Schaffhouse', 'Schwytz', 'Sembrancher', 'Sempach', 'Sion', 'Soleure', 'Splügen', 'Stans', 'Steckborn', 'Stein am Rhein', 'Sursee', 'Thoune', 'Thusis', 'Unterseen', 'Uznach', 'Valangin', 'Vevey', 'Villeneuve', 'Viège', 'Waldenburg', 'Walenstadt', 'Wangen an der Aare', 'Werdenberg', 'Wiedlisbach', 'Wil', 'Willisau', 'Winterthour', 'Yverdon-les-Bains', 'Zofingue', 'Zoug', 'Zurich'


Could you split this line for easier reading? Also, what's the datasource?

r3h6 · 2015-10-20T20:50:23Z

Code splitted to lines for easier reading.

Add missing static method for streetPrefix.

I choosed a format with "short" and "name" key for accessing the values more easy for a canton name and short name pair.
Otherwise you must use some sort of array_keys($canton) to get the short name of the pair.
If you like just one of them, then you can use the convenience methods cantonName or cantonShort.

If you prefer the key => value pair, I will change that.

fzaninotto · 2015-10-21T07:59:58Z

For the text providers, please extend the providers from other locales rather than copying them.

fzaninotto · 2015-10-21T08:00:43Z

src/Faker/Provider/de_CH/Person.php

+        'Zdenka', 'Zehra', 'Zenta', 'Zeynep', 'Zita', 'Zofia',
+    );
+
+    protected static $lastName = array(


missing datasource

fzaninotto · 2015-10-21T08:02:04Z

yes, please switch to key/value paris for cantons

r3h6 · 2015-10-21T14:23:36Z

Copied providers from other packages now extend these instead of duplicate code.
Text provider in package de_CH is still a copy because in Switzerland we don't use the char ß.
Lines to long: which package is a good example? Or max 80 chars?

r3h6 · 2015-11-08T19:33:07Z

Should I do still some changes to the code?

[FEATURE] New providers de_CH, fr_CH, it_CH

https://github.com/fzaninotto/Faker/releases/tag/v1.6.0 fzaninotto/Faker#739 fzaninotto/Faker@54b9e41

r3h6 added 2 commits October 16, 2015 21:06

[FEATURE] New providers de_CH, fr_CH, it_CH

54b9e41

[BUGFIX] Fixed fr_CH Provider. Now passing unit tests.

ddaf519

fzaninotto reviewed Oct 19, 2015
View reviewed changes

r3h6 added 2 commits October 20, 2015 22:41

[CLEANUP] Add doc comments. Break lines.

8183253

[TASK] Update test for format address

0097f31

fzaninotto reviewed Oct 21, 2015
View reviewed changes

r3h6 added 3 commits October 21, 2015 16:08

[TASK] Change cantons to key value pairs

fab81f4

[TASK] Extend text providers from other local provider

ee0d477

[TASK] Extend person provider from other local providers

c0e60c8

[CLEANUP] Newline at end of file

12d99a9

fzaninotto added a commit that referenced this pull request Nov 9, 2015

Merge pull request #739 from r3h6/feature/de_CH

cd5fb1c

[FEATURE] New providers de_CH, fr_CH, it_CH

fzaninotto merged commit cd5fb1c into fzaninotto:master Nov 9, 2015

r3h6 deleted the feature/de_CH branch November 9, 2015 08:40

Gummibeer added a commit to elbgoods/laravel-addressable that referenced this pull request Jul 22, 2020

swiss address faker requires at least v1.6.0

8aaa44f

https://github.com/fzaninotto/Faker/releases/tag/v1.6.0 fzaninotto/Faker#739 fzaninotto/Faker@54b9e41

Gummibeer mentioned this pull request Jul 22, 2020

add US & CZ address formats and use localized Faker elbgoods/laravel-addressable#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] New providers de_CH, fr_CH, it_CH #739

[FEATURE] New providers de_CH, fr_CH, it_CH #739

r3h6 commented Oct 16, 2015

r3h6 commented Oct 18, 2015

fzaninotto Oct 19, 2015

r3h6 commented Oct 20, 2015

fzaninotto commented Oct 21, 2015

fzaninotto Oct 21, 2015

fzaninotto commented Oct 21, 2015

r3h6 commented Oct 21, 2015

r3h6 commented Nov 8, 2015

[FEATURE] New providers de_CH, fr_CH, it_CH #739

[FEATURE] New providers de_CH, fr_CH, it_CH #739

Conversation

r3h6 commented Oct 16, 2015

r3h6 commented Oct 18, 2015

fzaninotto Oct 19, 2015

Choose a reason for hiding this comment

r3h6 commented Oct 20, 2015

fzaninotto commented Oct 21, 2015

fzaninotto Oct 21, 2015

Choose a reason for hiding this comment

fzaninotto commented Oct 21, 2015

r3h6 commented Oct 21, 2015

r3h6 commented Nov 8, 2015