Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Serialized $res key #749

Merged
merged 1 commit into from
Nov 27, 2015
Merged

Serialized $res key #749

merged 1 commit into from
Nov 27, 2015

Conversation

EmanueleMinotto
Copy link
Contributor

Closes #748

Since $res could be anything, it could also be an array or an object, so it must be serialized to be used for key checking.

@dlondero
Copy link

Agree with @EmanueleMinotto. Was about to open an issue for a problem with dateTimeBetween in conjunction with UniqueGenerator: in this case $res is a DateTime object which was ok for the previous implementation (see #491) using in_array but definitely not ok for array_key_exists.

fzaninotto added a commit that referenced this pull request Nov 27, 2015
@fzaninotto fzaninotto merged commit 47df6ab into fzaninotto:master Nov 27, 2015
@fzaninotto
Copy link
Owner

Thanks!

@vlakoff
Copy link
Contributor

vlakoff commented Nov 27, 2015

I suppose serialize($res) should be moved out of the loop. I had been too fast, please ignore this comment ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants