Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Added en_PH unit test folder + AddressTest.php #773

Merged
merged 3 commits into from
Feb 23, 2016
Merged

Added en_PH unit test folder + AddressTest.php #773

merged 3 commits into from
Feb 23, 2016

Conversation

jremes-foss
Copy link
Contributor

Added unit test folder and AddressTest.php for en_PH Provider.

Thank you.


use Faker\Generator;
use Faker\Provider\en_PH\Address;
use Faker\Provider\en_PH\Person;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Im not mistaking, this class is never used and can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I thought I removed it. O.o

But apparently, I did not.

Sorry for inconvenience.

@jremes-foss
Copy link
Contributor Author

That's it, the unused class is now removed.

@jremes-foss
Copy link
Contributor Author

That's a random build fail again:

1) Faker\Test\Provider\InternetTest::testIpv4NotLocalNetwork
Failed asserting that '1.46.124.204' does not match PCRE pattern "/\A1\./".

fzaninotto added a commit that referenced this pull request Feb 23, 2016
Added en_PH unit test folder + AddressTest.php
@fzaninotto fzaninotto merged commit df84324 into fzaninotto:master Feb 23, 2016
@fzaninotto
Copy link
Owner

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants