This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Use generator to populate values for numeric fields for Spot provider. #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll leave the Doctrine builder to the Doctrine maintainer. |
fzaninotto
added a commit
that referenced
this pull request
Feb 4, 2016
Use generator to populate values for numeric fields for Spot provider.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can do the same changes for Doctrine, BUT it will change values for existing seeds (randomFloat has different functionality than it's there now).
Given that Spot provider is new, I think we can afford changes here.
So, what do you think about Doctrine?