Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

improved Austrian names, states and realtext #826

Merged
merged 5 commits into from
Feb 20, 2016

Conversation

Findus23
Copy link
Contributor

'Petra',
'Sabine', 'Sabrina', 'Sandra', 'Sarah', 'Selina', 'Sonja', 'Sophia', 'Sophie', 'Stefanie',
'Tanja', 'Theresa',
'Valentina', 'Vanessa', 'Verena', 'Viktoria',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed that.

@fzaninotto
Copy link
Owner

Interesting, but there aren't enough first names for the AT locale. Can you add more?

@Findus23
Copy link
Contributor Author

I have now added the whole list (Top 60). Now it contains the names of 60 to 80% of the population. (Apparently we aren't that creative when it comes to names)

@fzaninotto
Copy link
Owner

I'm really surprised. Every other locale has several hundreds of names. Perhaps you need a better data source?

Also, could you rebase now that the other PR is merged?

@Findus23
Copy link
Contributor Author

Unfortunately there is no official list of names like in Switzerland and it's hard to use baby names like in Great Britain because they are only published as an (ugly) PDF: http://www.statistik.at/wcm/idc/idcplg?IdcService=GET_PDF_FILE&RevisionSelectionMethod=LatestReleased&dDocName=057950 (Overview)

Most (European) countries I checked have about the same number of first names. (e.g France https://github.com/fzaninotto/Faker/blob/master/src/Faker/Provider/fr_FR/Person.php)

@fzaninotto
Copy link
Owner

OK, fair enough.

fzaninotto added a commit that referenced this pull request Feb 20, 2016
improved Austrian names, states and realtext
@fzaninotto fzaninotto merged commit d8c0beb into fzaninotto:master Feb 20, 2016
@Findus23
Copy link
Contributor Author

Thanks for merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants