This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
docs: Clarify that randomElements() does not repeat input elements #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,7 +156,7 @@ public static function randomAscii() | |||
| } | |||
|
|
|||
| /** | |||
| * Returns random elements from a provided array | |||
| * Returns random elements from a provided array (not repeating input indices) | |||
There was a problem hiding this comment.
I don't understand your comment
There was a problem hiding this comment.
What about this?
Returns randomly ordered subsequence of $count elements from a provided array
I want for the other users to be clear that the function does not repeat input elements. The current comment does not say it.
sustmi
force-pushed
the
docs-clarify-random-elements
branch
from
4c6f71b
to
7978ddc
Compare
|
I updated the pull request with the new sentence. |
fzaninotto
added a commit
that referenced
this pull request
Mar 10, 2016
docs: Clarify that randomElements() does not repeat input elements
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not clear for me whether randomElements() repeats input elements or not until I looked into the implementation.