This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Added Lorempixel check for ImageTest.php #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $httpCode = curl_getinfo($curlPing, CURLINFO_HTTP_CODE); | ||
| curl_close($curlPing); | ||
|
|
||
| if ($httpCode >= 200 && $httpCode < 300) |
There was a problem hiding this comment.
I suggest you reverse the logic:
if ($httpCode < 200 || $httpCode > 300) {
$this-> markTestSkipped('LoremPixel is offline, skipping image download');
return;
}cf. http://refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html
There was a problem hiding this comment.
Sure, this can be done.
|
Looks like the ImageTest check works as intended: |
| curl_close($curlPing); | ||
|
|
||
| /** | ||
| * If HTTP response is something else than 200-299, skip the test |
There was a problem hiding this comment.
unnecessary, the code speaks for itself
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
curlcheck to filetest/Faker/Provider/ImageTest.phpto test LoremPixel before conducting the unit tests.Basically, this check utilises
curlto retrieve HTTP header. If header includes response code which is between 200 and 299, unit tests are being conducted. Otherwise, they are skipped.