-
Notifications
You must be signed in to change notification settings - Fork 3.6k
ka_GE: overall improvements to ka_GE locale #913
Conversation
General improvemens were made to existing Provides as well as added Company and Lorem providers (generators) ka_GE\Address: * trimed items in arrays * added multiple address formats (full, short and etc.) * added cityFormats * added regionGenitiveForm (gramar) ka_GE\Company: * generates names using popular name elements with affixes ka_GE\Internet: * added items to freeEmailDomain array * added all supported Georgian TLDs ka_GE\Lorem: * added about 300 localized lorem words ka_GE\Person: * added titles for genders
/cc @fzaninotto All Green. |
Lorem is never localized, please remove this class. |
@@ -0,0 +1,59 @@ | |||
<?php | |||
/** | |||
* Created by IntelliJ IDEA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this phpDoc
@fzaninotto Is there any specific reason why Lorem is never localized? Because when using |
Removes IDE file template phpDoc
There's a provider for that. It's called Text. On Tue, May 17, 2016, 22:23 Giorgi Kotchlamazashvili <
|
@okj579 The To rephrase: When I want to generate a random localized word, sentence or paragraph the most intuitive would be to call the respective methods on Generator instance. There's no good way of doing those using realText as it generates a text up to $maxNbChars. Also realText could return newlines, parts of a word, punctuations and what not. So again: @fzaninotto Could you please elaborate a bit why "Lorem is never localised"? |
Lorem is for text that is in no language. For real language, use the Text provider. If you need words and sentences with realtext, then we should add new methods (like |
…ompany name generator
@fzaninotto Thanks for the explanation. I've removed the lorem provider.
Yes. I definitely need a way to generate dummy localized So... How should we proceed? |
Thanks for this PR. For localized text, I suggest you work on the base |
General improvemens were made to existing Provides as well
as added Company and Lorem providers (generators)
ka_GE\Address:
ka_GE\Company:
ka_GE\Internet:
ka_GE\Lorem:
ka_GE\Person: