This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Harmonize fr_*\Company #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class Company extends \Faker\Provider\fr_FR\Company | ||
| { | ||
| // |
There was a problem hiding this comment.
Are you talking about line 7 ?
|
@fzaninotto I have amended the commits, thanks |
| * @note Randomly took 100 from this list | ||
| */ | ||
| protected static $jobTitleFormat = array( | ||
| 'Elagueur-botteur', |
There was a problem hiding this comment.
Please sort these alphabetically
Usefull when nothing is defined, it relies on fr_FR, since it's the same spoken lang.
|
|
||
| /** | ||
| * @link http://www.pole-emploi.fr/candidat/le-code-rome-et-les-fiches-metiers-@/article.jspz?id=60702 | ||
| * @note Randomly took 300 from this list |
There was a problem hiding this comment.
@fzaninotto At that point... Why not make it 300 ?
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.