Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Added missing grayscale option/flag to Image provider #928

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

sebastianvilla
Copy link
Contributor

LoremPixel offers a grayscale option which was already available in the imageUrl method in the Image provider; however, this option was missing in theimage method.

@fzaninotto
Copy link
Owner

Please update the README accordingly

@fzaninotto
Copy link
Owner

bump

@localheinz
Copy link
Contributor

localheinz commented Jun 13, 2019

Also see #1712 and #1713 and #1714.

@pimjansen
Copy link
Contributor

Only missing some tests to confirm the url generation. @sebastianvilla is this something you can add? I know it is a quite old PR though

Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz
Copy link
Contributor

@pimjansen

Let's merge and follow up!

@pimjansen pimjansen merged commit 2063ee6 into fzaninotto:master Aug 24, 2019
@pimjansen
Copy link
Contributor

Thanks for your participation 👌🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants