Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

fix 32bits issue #953

Merged
merged 2 commits into from
Jul 1, 2016
Merged

fix 32bits issue #953

merged 2 commits into from
Jul 1, 2016

Conversation

remicollet
Copy link
Contributor

From Fedora QA, on 32bits

There were 2 errors:
1) Faker\Test\Provider\DateTimeTest::testDateTimeAD
mt_rand() expects parameter 1 to be integer, float given
/builddir/build/BUILDROOT/php-Faker-1.5.0-5.fc25.noarch/usr/share/php/Faker/Provider/DateTime.php:56
/builddir/build/BUILD/Faker-d0190b156bcca848d401fb80f31f504f37141c8d/test/Faker/Provider/DateTimeTest.php:27
2) Faker\Test\Provider\DateTimeTest::testFixedSeedWithMaximumTimestamp
mt_rand() expects parameter 1 to be integer, float given
/builddir/build/BUILDROOT/php-Faker-1.5.0-5.fc25.noarch/usr/share/php/Faker/Provider/DateTime.php:56
/builddir/build/BUILD/Faker-d0190b156bcca848d401fb80f31f504f37141c8d/test/Faker/Provider/DateTimeTest.php:83

@remicollet
Copy link
Contributor Author

Second commit is for

There was 1 error:
1) Faker\Test\Provider\InternetTest::testLocalIpv4
mt_rand() expects parameter 1 to be integer, float given
/builddir/build/BUILDROOT/php-Faker-1.5.0-6.fc25.noarch/usr/share/php/Faker/Provider/Base.php:119
/builddir/build/BUILDROOT/php-Faker-1.5.0-6.fc25.noarch/usr/share/php/Faker/Provider/Internet.php:317
/builddir/build/BUILD/Faker-d0190b156bcca848d401fb80f31f504f37141c8d/test/Faker/Provider/InternetTest.php:103

@fzaninotto fzaninotto merged commit 6b7ebbb into fzaninotto:master Jul 1, 2016
@fzaninotto
Copy link
Owner

Thanks!

@remicollet remicollet deleted the issue-32bits branch July 1, 2016 08:54
@remicollet
Copy link
Contributor Author

Thanks for the quick merge.

FYI, Fedora QA history for this package:
https://apps.fedoraproject.org/koschei/package/php-Faker?collection=f25

While travis raise build on code change, Koschei raise build on dependency change, which is complementary. And travis is x86_64 only.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants