Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion control handle jumps when switching fixed reference frame in Rviz2 #199

Closed

Conversation

Hydran00
Copy link

@Hydran00 Hydran00 commented Jun 2, 2024

Hi,
I noticed that the motion control handle jumps in a wrong pose when I change the Fixed Frame under Global Options in Rviz2. This happens as soon as I try to move the handle after switching the fixed frame. I managed to solve this error with minor modification accounting for the header of the feedback message coming from the handle when the

m_server->setPose(...)

is called in the updateMotionControlCallback function.
I also added a check on the frame_id in the update function to prevent the selection of a non-fixed frame.

@stefanscherzinger
Copy link
Contributor

Thanks @Hydran00 for spotting this! I'll have a look.

@stefanscherzinger
Copy link
Contributor

@Hydran00
I merged this in #213.
Notice that I couldn't merge your PR directly, because code formatting was needed and you didn't allow changes on your fork, more info here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants