Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement code generation for NaiveDate #1608

Closed
TrackerSB opened this issue Jan 4, 2024 · 7 comments · Fixed by #1631
Closed

Implement code generation for NaiveDate #1608

TrackerSB opened this issue Jan 4, 2024 · 7 comments · Fixed by #1631
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TrackerSB
Copy link
Contributor

I'm using diesel to generate structs representing database entries. Given a PostgreSQL schema having a column of type date it generates a struct with a member of type NaiveDate for which IntoDart is not implemented. Trying to do so instantly runs into rusts orphan restriction.

Given that IntoDart<NaiveDateTime> is already implemented a solution should be already within reach, I naively assume.

For the time being I can live with changing the column type to timestamp, i.e. including a time resulting in NaiveDateTime.

@TrackerSB TrackerSB added the enhancement New feature or request label Jan 4, 2024
Copy link

welcome bot commented Jan 4, 2024

Hi! Thanks for opening your first issue here! 😄

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 4, 2024

Looks reasonable and feel free to PR! flutter_rust_bridge uses allo-isolate's IntoDart, thus the procedure is to PR on https://github.com/shekohex/allo-isolate/blob/master/src/chrono.rs#L56 (just mimic existing ones), and then update flutter_rust_bridge.

@fzyzcjy fzyzcjy added the good first issue Good for newcomers label Jan 4, 2024
@TrackerSB
Copy link
Contributor Author

--> shekohex/allo-isolate#56

@fzyzcjy fzyzcjy added the awaiting Waiting for responses, PR, further discussions, upstream release, etc label Jan 5, 2024
@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 13, 2024

(close since PR merged)

@fzyzcjy fzyzcjy closed this as completed Jan 13, 2024
@TrackerSB
Copy link
Contributor Author

Thanks a lot for fixing and merging the PR!

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 13, 2024

You are welcome!

Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
@fzyzcjy fzyzcjy removed the awaiting Waiting for responses, PR, further discussions, upstream release, etc label Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants