Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrono: Add support for NaiveDate #56

Merged
merged 6 commits into from
Jan 7, 2024
Merged

chrono: Add support for NaiveDate #56

merged 6 commits into from
Jan 7, 2024

Conversation

TrackerSB
Copy link
Contributor

No description provided.

@TrackerSB TrackerSB marked this pull request as draft January 5, 2024 06:51
@TrackerSB TrackerSB marked this pull request as ready for review January 5, 2024 06:51
@shekohex
Copy link
Owner

shekohex commented Jan 5, 2024

CI needs fixes.

@TrackerSB TrackerSB marked this pull request as draft January 5, 2024 10:09
@shekohex shekohex self-requested a review January 5, 2024 11:50
@shekohex
Copy link
Owner

shekohex commented Jan 5, 2024

Looks like you need to run cargo fmt over the code.

Copy link
Owner

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Thank you for adding this feature.

@TrackerSB TrackerSB marked this pull request as ready for review January 5, 2024 15:53
@TrackerSB
Copy link
Contributor Author

What's the procedure of integrating the PR?

@shekohex shekohex merged commit 8758114 into shekohex:master Jan 7, 2024
5 checks passed
@shekohex
Copy link
Owner

shekohex commented Jan 7, 2024

What's the procedure of integrating the PR?

I will publish a new package version very soon.

@TrackerSB TrackerSB deleted the supportNaiveDateIntoDart branch January 7, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants