Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build.rs configuration documentations #1742

Closed
patmuk opened this issue Feb 8, 2024 · 4 comments · Fixed by #1743
Closed

Improve build.rs configuration documentations #1742

patmuk opened this issue Feb 8, 2024 · 4 comments · Fixed by #1743
Labels
bug Something isn't working

Comments

@patmuk
Copy link
Contributor

patmuk commented Feb 8, 2024

Describe the bug

When trying to implement a build.rs, so changes in the rust code trigger code generation, I stumbled over the following issues:

  1. The example build.rs in the documentation does not exist.

Another build.rs can be found here, its cargo.toml points to the local frb repository (as CI should take the latest unpublished code).
However, it is not documented what needs to be imported when using the published code.

Steps to reproduce

Works, if the missing peaces are figured ;)

Logs

not applicable

Expected behavior

No response

Generated binding code

No response

OS

No response

Version of flutter_rust_bridge_codegen

No response

Flutter info

No response

Version of clang++

No response

Additional context

I will create a small PR describing the setup better and fixing the link :)

@patmuk patmuk added the bug Something isn't working label Feb 8, 2024
@fzyzcjy
Copy link
Owner

fzyzcjy commented Feb 8, 2024

Totally agree! Seems that #1696 does not fully update everything. Thus maybe:

@fzyzcjy fzyzcjy changed the title in v2, build.rs configuration is not clear Improve build.rs configuration documentations Feb 8, 2024
@patmuk
Copy link
Contributor Author

patmuk commented Feb 8, 2024

Ups, did not see that PR!
I will do these in a new PR (now).

@fzyzcjy
Copy link
Owner

fzyzcjy commented Feb 8, 2024

Take your time! (I have edited my comment above)

Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants