-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves the documentation on how to configure build.rs #1743
Improves the documentation on how to configure build.rs #1743
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1743 +/- ##
==========================================
- Coverage 99.27% 99.25% -0.02%
==========================================
Files 357 357
Lines 14813 14813
==========================================
- Hits 14705 14703 -2
- Misses 108 110 +2 ☔ View full report in Codecov by Sentry. |
@fzyzcjy I guess all is fine (except for you to have an editorial look upon the proposed reformulation).
|
Just flaky, no worries! |
@fzyzcjy thanks for the corrections! |
You are welcome! |
Changes
Fixes #1742
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.@fzyzcjy please not that I took the liberty to change the md-file to have one sentence per line. In this way, future changes are easier to see in the diff. The output should not be affected by this reformatting.
Probably my description is a bit to verbose - feel free to reformulate or ask me to do so!