refactor: remove double-allocation for enum CST decode #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desdaemon
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1500 +/- ##
==========================================
- Coverage 99.20% 99.19% -0.01%
==========================================
Files 341 341
Lines 13141 13098 -43
==========================================
- Hits 13036 12993 -43
Misses 105 105 ☔ View full report in Codecov by Sentry. |
Desdaemon
force-pushed
the
remove-enum-alloc
branch
from
2c7c862
to
e51110c
Compare
fzyzcjy
reviewed
Dec 27, 2023
...n/src/library/codegen/generator/wire/rust/spec_generator/codec/cst/decoder/ty/enumeration.rs
Outdated
Show resolved
Hide resolved
|
Great optimization! Just two nits (discussions). |
Desdaemon
force-pushed
the
remove-enum-alloc
branch
3 times, most recently
from
af8af19
to
1f48422
Compare
fzyzcjy
reviewed
Dec 28, 2023
Desdaemon
force-pushed
the
remove-enum-alloc
branch
from
1f48422
to
706e04e
Compare
|
(I will review after a sleep, roughly 8 hours later - with a brief look this LGTM and ready to merge :) ) |
fzyzcjy
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
(CST) Remove
*mut Enum_Variantand inflate functions in favor ofMaybeUninit. This reduces 1-2 allocations per enum instantiation and should reduce binary size somewhat.Checklist
./frb_internal precommit --mode slow(orfast) is run (it internal runs code generator, does auto formatting, etc)../websitefolder) are updated.Remark for PR creator
./frb_internal --helpshows utilities for development.