Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc about movement of things like StreamSink #1703

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Add doc about movement of things like StreamSink #1703

merged 2 commits into from
Jan 24, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jan 24, 2024

Changes

Close #1701

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review January 24, 2024 09:32
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (202b74e) 99.27% compared to head (1357228) 99.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
- Coverage   99.27%   99.26%   -0.02%     
==========================================
  Files         354      354              
  Lines       14660    14660              
==========================================
- Hits        14554    14552       -2     
- Misses        106      108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 469f5ab into master Jan 24, 2024
90 of 93 checks passed
@fzyzcjy fzyzcjy deleted the feat/1701 branch January 24, 2024 11:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0-dev.21 moves RustOpaque and StreamSink compared with previous beta versions, causing confusion
1 participant