Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically upgrade flutter_rust_bridge Dart/Rust runtime versions when running generate #1704

Merged
merged 61 commits into from
Jan 25, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jan 24, 2024

Changes

Close #1700

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review January 24, 2024 13:07
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f7b8e9e) 99.26% compared to head (7947ee6) 99.26%.

Files Patch % Lines
frb_codegen/src/binary/commands.rs 0.00% 1 Missing ⚠️
...degen/src/library/codegen/polisher/auto_upgrade.rs 97.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1704   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files         354      356    +2     
  Lines       14669    14749   +80     
=======================================
+ Hits        14561    14641   +80     
  Misses        108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit f38da2c into master Jan 25, 2024
94 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a more convenient way to update the flutter_rust_bridge dependency version?
1 participant