Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoring all methods of a struct #1730

Merged
merged 13 commits into from
Feb 8, 2024
Merged

Support ignoring all methods of a struct #1730

merged 13 commits into from
Feb 8, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Feb 6, 2024

Changes

Close #1715

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Support ignoring all methods of a struct Support ignoring a struct Feb 6, 2024
@fzyzcjy fzyzcjy changed the title Support ignoring a struct Support ignoring all methods of a struct Feb 6, 2024
@fzyzcjy fzyzcjy marked this pull request as ready for review February 6, 2024 13:12
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b1ec3c6) 99.26% compared to head (2df9b98) 99.24%.
Report is 6 commits behind head on master.

❗ Current head 2df9b98 differs from pull request most recent head c356f04. Consider uploading reports for the commit c356f04 to get more accurate results

Files Patch % Lines
...egen/src/library/codegen/parser/type_parser/mod.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
- Coverage   99.26%   99.24%   -0.03%     
==========================================
  Files         357      357              
  Lines       14767    14773       +6     
==========================================
+ Hits        14659    14662       +3     
- Misses        108      111       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	frb_example/pure_dart_pde/lib/src/rust/frb_generated.dart
#	frb_example/pure_dart_pde/rust/src/frb_generated.rs
@fzyzcjy fzyzcjy merged commit f4d5f48 into master Feb 8, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Struct Ignore or if possible we can Ignore whole mod
1 participant