Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ffigen upgrades #1757

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Add support for ffigen upgrades #1757

merged 7 commits into from
Mar 6, 2024

Conversation

aran
Copy link
Contributor

@aran aran commented Feb 16, 2024

Changes

Fixes #1429

This softens the ffigen requirement. ensure_tool_available still ensures ffigen is available, but doesn't cap the version.

ffigen 11 introduces a breaking change (https://pub.dev/packages/ffigen/changelog#1100) which can be disabled with a new ignore-source-errors flag. Will see from CI if that flag is needed for frb. I saw unrelated errors from ./frb_internal on master.

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (9fdcce2) to head (0f07e1e).

❗ Current head 0f07e1e differs from pull request most recent head 2448a4d. Consider uploading reports for the commit 2448a4d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1757      +/-   ##
==========================================
- Coverage   99.26%   96.15%   -3.12%     
==========================================
  Files         358      357       -1     
  Lines       14948    14759     -189     
==========================================
- Hits        14838    14191     -647     
- Misses        110      568     +458     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Only some nits

@fzyzcjy fzyzcjy changed the base branch from master to feat/1757 March 6, 2024 05:04
@fzyzcjy fzyzcjy merged commit 2fe4d64 into fzyzcjy:feat/1757 Mar 6, 2024
42 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ffigen 10.x
2 participants