-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ffigen upgrades #1757
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1757 +/- ##
==========================================
- Coverage 99.26% 96.15% -3.12%
==========================================
Files 358 357 -1
Lines 14948 14759 -189
==========================================
- Hits 14838 14191 -647
- Misses 110 568 +458 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Only some nits
frb_codegen/assets/integration_template/rust_builder/pubspec.yaml
Outdated
Show resolved
Hide resolved
…ficient to ensure the tool is available.
…emplate/rust_builder/pubspec.yaml
Changes
Fixes #1429
This softens the
ffigen
requirement. ensure_tool_available still ensures ffigen is available, but doesn't cap the version.ffigen 11 introduces a breaking change (https://pub.dev/packages/ffigen/changelog#1100) which can be disabled with a new
ignore-source-errors
flag. Will see from CI if that flag is needed for frb. I saw unrelated errors from ./frb_internal on master.Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.