Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide hints when struct/enum is never used #1763

Merged
merged 6 commits into from
Feb 17, 2024
Merged

Provide hints when struct/enum is never used #1763

merged 6 commits into from
Feb 17, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Feb 17, 2024

Changes

Close #1747

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review February 17, 2024 02:50
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbfb3eb) 99.25% compared to head (6c516d2) 99.25%.
Report is 30 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1763   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files         357      357           
  Lines       14813    14827   +14     
=======================================
+ Hits        14703    14717   +14     
  Misses        110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit e8dd470 into master Feb 17, 2024
101 of 102 checks passed
@fzyzcjy fzyzcjy deleted the feat/1747 branch February 17, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a struct is never used in any functions, it is silently ignored, causing confusion for the users
1 participant