Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): generate decl of store_dart_post_cobject when full_dep enabled #1773

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

Berrysoft
Copy link
Contributor

@Berrysoft Berrysoft commented Feb 22, 2024

Changes

Fixes #1772

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

welcome bot commented Feb 22, 2024

Hi! Thanks for opening this pull request! 😄

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfd8862) 99.25% compared to head (5c4fd64) 99.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1773      +/-   ##
==========================================
+ Coverage   99.25%   99.26%   +0.01%     
==========================================
  Files         357      357              
  Lines       14856    14856              
==========================================
+ Hits        14745    14747       +2     
+ Misses        111      109       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Feb 22, 2024

Good job! I will re-run the CI since it seems to be merely flaky.

@Berrysoft
Copy link
Contributor Author

The two failed checks seemed not finding chrome.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Feb 22, 2024

I agree, maybe the underlying github ci has upgraded etc. Will check a bit later when having time.

@fzyzcjy fzyzcjy merged commit ae2916b into fzyzcjy:master Feb 25, 2024
102 checks passed
Copy link

welcome bot commented Feb 25, 2024

Hi! Congrats on merging your first pull request! 🎉

@fzyzcjy
Copy link
Owner

fzyzcjy commented Feb 25, 2024

@all-contributors please add @Berrysoft for code

Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @Berrysoft! 🎉

@Berrysoft Berrysoft deleted the fix/full-dep-decl branch February 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The bridge always wants to load a framework on iOS
2 participants