Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type char #1957

Merged
merged 30 commits into from
May 20, 2024
Merged

Support type char #1957

merged 30 commits into from
May 20, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented May 19, 2024

Changes

Close #1935

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review May 19, 2024 12:03
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (51954da) to head (9023ed2).
Report is 39 commits behind head on master.

Current head 9023ed2 differs from pull request most recent head ec6a0e3

Please upload reports for the commit ec6a0e3 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
- Coverage   99.22%   99.22%   -0.01%     
==========================================
  Files         371      369       -2     
  Lines       15841    15829      -12     
==========================================
- Hits        15719    15707      -12     
  Misses        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	frb_example/pure_dart/lib/src/rust/frb_generated.dart
#	frb_example/pure_dart/rust/src/frb_generated.rs
#	frb_example/pure_dart_pde/lib/src/rust/frb_generated.dart
#	frb_example/pure_dart_pde/rust/src/frb_generated.rs
@fzyzcjy fzyzcjy merged commit 2b87aac into master May 20, 2024
99 checks passed
@fzyzcjy fzyzcjy deleted the feat/12029 branch May 20, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For char types, use String on the Dart side.
1 participant