Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #[frb(generate_impl_enum)] ; Fix overriding attributes in third party crates for traits #2046

Merged
merged 162 commits into from
Jun 8, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 8, 2024

Changes

Please list issues fixed by this PR here, using format "Fixes #the-issue-number".

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy mentioned this pull request Jun 8, 2024
5 tasks
@fzyzcjy fzyzcjy marked this pull request as ready for review June 8, 2024 07:32
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 96.50735% with 19 lines in your changes missing coverage. Please review.

Project coverage is 96.95%. Comparing base (76cdb39) to head (e6b38f3).

Files Patch % Lines
...degen/src/library/utils/basic_code/general_code.rs 71.15% 15 Missing ⚠️
.../src/library/utils/basic_code/simple_code_trait.rs 90.47% 2 Missing ⚠️
...egen/src/library/codegen/generator/api_dart/mod.rs 91.66% 1 Missing ⚠️
...n/src/library/codegen/generator/misc/path_texts.rs 98.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   98.25%   96.95%   -1.31%     
==========================================
  Files         453      459       +6     
  Lines       17807    18095     +288     
==========================================
+ Hits        17497    17544      +47     
- Misses        310      551     +241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit bf67b72 into master Jun 8, 2024
97 of 106 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant