Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically strip prefix set_/get_ when it is a setter/getter function #2058

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 9, 2024

Changes

Close #1996

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review June 10, 2024 00:02
@fzyzcjy fzyzcjy changed the title Automatically strip prefix set_/get_ when it is a setter/getter function [WIP] Automatically strip prefix set_/get_ when it is a setter/getter function Jun 10, 2024
@fzyzcjy fzyzcjy changed the title [WIP] Automatically strip prefix set_/get_ when it is a setter/getter function Automatically strip prefix set_/get_ when it is a setter/getter function Jun 10, 2024
@fzyzcjy fzyzcjy merged commit 9b49798 into master Jun 10, 2024
@fzyzcjy fzyzcjy deleted the feat/12197 branch June 10, 2024 03:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to automatically strip get_ or set_ prefixes from struct impl
1 participant