Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding errors to stream sink #2059

Merged
merged 26 commits into from
Jun 10, 2024
Merged

Support adding errors to stream sink #2059

merged 26 commits into from
Jun 10, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 10, 2024

Changes

Close #2036

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title [WIP] Support adding errors to stream sink Support adding errors to stream sink Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.08%. Comparing base (9b49798) to head (634897e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2059   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         470      470           
  Lines       18576    18608   +32     
=======================================
+ Hits        18406    18438   +32     
  Misses        170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit b7e4a08 into master Jun 10, 2024
106 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to catch error when use StreamSink?
1 participant