Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #[frb(name)] on fields to rename them ; Automatically rename Dart field names if they conflict with Dart keywords #2070

Merged
merged 40 commits into from
Jun 12, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 12, 2024

Changes

Close #2066

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Support #[frb(name)] on fields to rename them Support #[frb(name)] on fields to rename them ; Automatically rename Dart field names if they conflict with Dart keywords Jun 12, 2024
@fzyzcjy fzyzcjy marked this pull request as ready for review June 12, 2024 06:31
@fzyzcjy fzyzcjy changed the title Support #[frb(name)] on fields to rename them ; Automatically rename Dart field names if they conflict with Dart keywords [to be rebased] Support #[frb(name)] on fields to rename them ; Automatically rename Dart field names if they conflict with Dart keywords Jun 12, 2024
@fzyzcjy fzyzcjy changed the title [to be rebased] Support #[frb(name)] on fields to rename them ; Automatically rename Dart field names if they conflict with Dart keywords Support #[frb(name)] on fields to rename them ; Automatically rename Dart field names if they conflict with Dart keywords Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.10%. Comparing base (c93793c) to head (71ebe0c).

Files Patch % Lines
frb_codegen/src/library/codegen/ir/mir/ident.rs 96.15% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2070   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         473      473           
  Lines       18919    18932   +13     
=======================================
+ Hits        18749    18762   +13     
  Misses        170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 89ff866 into master Jun 12, 2024
105 of 106 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict between keywords in Rust and Dart
1 participant