Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoring a whole module by #[frb(ignore)] on module ; Support /// frb:... #2085

Merged
merged 15 commits into from
Jun 14, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 14, 2024

Changes

Close #2074

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Support ignoring a whole module by #[frb(ignore)] on module Support ignoring a whole module by #[frb(ignore)] on module ; Support /// frb:... Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (954c966) to head (e7c2176).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2085   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         473      473           
  Lines       18922    18963   +41     
=======================================
+ Hits        18756    18798   +42     
+ Misses        166      165    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit d388b6d into master Jun 14, 2024
105 of 106 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated code reference to private module and makes errors
1 participant