Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint users when having references in output type, hint when wrong rust_input, add flutter_package example, and improve docs #2100

Merged
merged 57 commits into from
Jun 19, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 18, 2024

Changes

Close #2083
Close #2084
Close #1969

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Hint users when having references in output type Hint users when having references in output type and improve docs Jun 18, 2024
@fzyzcjy fzyzcjy changed the title Hint users when having references in output type and improve docs Hint users when having references in output type, hint when wrong rust_input, and improve docs Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (39c1f80) to head (95e11b2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
+ Coverage   98.41%   99.11%   +0.70%     
==========================================
  Files         485      485              
  Lines       19597    19635      +38     
==========================================
+ Hits        19286    19461     +175     
+ Misses        311      174     -137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy marked this pull request as ready for review June 19, 2024 02:24
@fzyzcjy fzyzcjy merged commit 43ba8a2 into master Jun 19, 2024
114 of 116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant