Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated output sorted when using proxy_enum and trait_impl #2115

Merged
merged 10 commits into from
Jun 19, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 19, 2024

Changes

Please list issues fixed by this PR here, using format "Fixes #the-issue-number".

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review June 19, 2024 11:02
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (e2a38d1) to head (e160864).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2115      +/-   ##
==========================================
+ Coverage   98.41%   99.11%   +0.70%     
==========================================
  Files         485      486       +1     
  Lines       19609    19656      +47     
==========================================
+ Hits        19298    19482     +184     
+ Misses        311      174     -137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 0177727 into master Jun 19, 2024
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant