Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell user reasons when skipping traits ; Allow using arbitrary frb attribute as an indicator to include an item #2121

Merged
merged 36 commits into from
Jun 20, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 20, 2024

Changes

Fixes #2103

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Tell user reasons when skipping in HIR parsing stage ; Enable translation of some trait impls when having attributes on it Tell user reasons when skipping in HIR parsing stage ; Allow using arbitrary frb attribute as an indicator to include an item Jun 20, 2024
@fzyzcjy fzyzcjy changed the title Tell user reasons when skipping in HIR parsing stage ; Allow using arbitrary frb attribute as an indicator to include an item Allow using arbitrary frb attribute as an indicator to include an item Jun 20, 2024
@fzyzcjy fzyzcjy changed the title Allow using arbitrary frb attribute as an indicator to include an item Tell user reasons when skipping traits ; Allow using arbitrary frb attribute as an indicator to include an item Jun 20, 2024
@fzyzcjy fzyzcjy marked this pull request as ready for review June 20, 2024 02:06
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 97.97980% with 6 lines in your changes missing coverage. Please review.

Project coverage is 99.12%. Comparing base (3ed6c2f) to head (8439c1b).

Files Patch % Lines
frb_codegen/src/library/codegen/ir/misc/skip.rs 89.65% 3 Missing ⚠️
...y/codegen/parser/mir/parser/function/real/owner.rs 90.00% 2 Missing ⚠️
...odegen/parser/mir/parser/function/real/argument.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2121    +/-   ##
========================================
  Coverage   99.11%   99.12%            
========================================
  Files         486      485     -1     
  Lines       19656    19793   +137     
========================================
+ Hits        19482    19619   +137     
  Misses        174      174            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 99c2738 into master Jun 20, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3rd party types can't be constructed
1 participant