Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle root module scenario in pub use transformer ; Improve hints when fails to parse a struct or enum #2124

Merged
merged 17 commits into from
Jun 21, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 20, 2024

Changes

Related: #2102

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Handle root module scenario in pub use transformer Handle root module scenario in pub use transformer ; Skip running compute_skips on early generation phase Jun 20, 2024
This reverts commit 4ff55a7.
@fzyzcjy fzyzcjy changed the title Handle root module scenario in pub use transformer ; Skip running compute_skips on early generation phase Handle root module scenario in pub use transformer Jun 20, 2024
@fzyzcjy fzyzcjy changed the title Handle root module scenario in pub use transformer Handle root module scenario in pub use transformer ; Improve hints when fails to parse a struct or enum Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (3716357) to head (1a56656).
Report is 4 commits behind head on master.

Current head 1a56656 differs from pull request most recent head 9632a5f

Please upload reports for the commit 9632a5f to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2124   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         485      485           
  Lines       19793    19800    +7     
=======================================
+ Hits        19619    19627    +8     
+ Misses        174      173    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy marked this pull request as ready for review June 21, 2024 04:57
@fzyzcjy fzyzcjy merged commit 07cf09d into master Jun 21, 2024
110 of 111 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant