-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle root module scenario in pub use transformer ; Improve hints when fails to parse a struct or enum #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzyzcjy
changed the title
Handle root module scenario in pub use transformer
Handle root module scenario in pub use transformer ; Skip running compute_skips on early generation phase
Jun 20, 2024
This reverts commit 4ff55a7.
fzyzcjy
changed the title
Handle root module scenario in pub use transformer ; Skip running compute_skips on early generation phase
Handle root module scenario in pub use transformer
Jun 20, 2024
fzyzcjy
changed the title
Handle root module scenario in pub use transformer
Handle root module scenario in pub use transformer ; Improve hints when fails to parse a struct or enum
Jun 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2124 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 485 485
Lines 19793 19800 +7
=======================================
+ Hits 19619 19627 +8
+ Misses 174 173 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related: #2102
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.