-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adds dart fix
when generating files
#2182
Conversation
Hi! Thanks for opening this pull request! 😄 |
Good idea! I wonder how long does it take (will it be very slow or not), and may I know what it fixes for your scenario? |
Probably 2~3x compared to
Yeah I'm grabbing some summary then I'll put it in the top comment. In general, people apply different lint rules in their libraries so this will help the generated files follow their rules. Also |
I see. Btw, there may be another way as well: what about using EDIT: If we want to ensure we ignore as many things as possible, we may also enable all linter rules in our frb_example/pure_dart test, then we will know what rules to ignore |
Do we have tests against the generated files? Like testing the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2182 +/- ##
==========================================
- Coverage 99.07% 99.06% -0.01%
==========================================
Files 487 488 +1
Lines 20160 20197 +37
==========================================
+ Hits 19974 20009 +35
- Misses 186 188 +2 ☔ View full report in Codecov by Sentry. |
Check .github/workflows/ci.yaml, iirc the |
How is this going on now? I also realize that some of the generated dart files would be changed slightly after running dart fix , like this:
|
I didn't find spare time to update this in recent weeks, but the feature is working on this branch. You can cherry-pick these commits to your fork and manually installs it. |
Hmm maybe just rerun it... Sometimes I do see weird flakiness EDIT: I have triggered rerun |
Could you also retrigger the codecov workflow? It seems to be throttled 😂 https://github.com/fzyzcjy/flutter_rust_bridge/actions/runs/10748747038/job/29815531574?pr=2182 |
Sure, done |
Hmm still throttled. Anything that might help with it? |
I seemed to have seen this throttling for several times... Have not searched deeply about it. Maybe you can firstly finish the pr and ready for review, and we can consider codecov before really merging. |
Okay so the PR should be good for review then. |
Great! I will review probably within a day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Only a small nit
@all-contributors please add @AlexV525 for code |
I've put up a pull request to add @AlexV525! 🎉 |
Looks great! |
Hi! Congrats on merging your first pull request! 🎉 |
Changes
Please list issues fixed by this PR here, using format "Fixes #the-issue-number".
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.