-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix geneartion of async
functions when default_dart_async: false
; Update frb_example/integrate_third_party
#2190
Conversation
Please, is there someone to explain me why this check was unsuccessful ? |
Click the "Details" button and we can see error logs. Looks like the codegen is not run. Thus try
on |
…rate` on frb_example/integrate_third_party
I would like to add a simple check that [#2178] is correctly fixed. How do you suggest doing that ? |
Since that issue happens in realworld (web audio api), the simplest way may be: Just copycode into frb_example/integrate_third_party, including the code that causes the problem (iirc it is |
…egrate_third_party/rust/src/frb_generated.rs
…egrate_third_party/rust/src/frb_generated.rs
…egrate_third_party/rust/src/frb_generated.rs
…egrate_third_party/rust/src/frb_generated.rs
async
functions when default_dart_async: false
; Update frb_example/integrate_third_party
Hi! Congrats on merging your first pull request! 🎉 |
Great job! |
Changes
Fixes #2178.
Fixes #2167.
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.