Don't try to cleanup folders that don't exist #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The folders android, ios, linux, windows and macos aren't always available after flutter create for plugins. Check if they exist before cleaning them up. This is to avoid runtime errors when trying to chane into non-existing folders.
|
Hi! Thanks for opening this pull request! 😄 |
|
Just to add: On Windows, I don't see macos and ios folders - they are not created with the plugin because they are not supported on windows development hosts. Since I have used |
fzyzcjy
approved these changes
Jul 19, 2024
|
Hi! Congrats on merging your first pull request! 🎉 |
|
Nice fix! |
|
@all-contributors please add @Markus43 for code |
|
I've put up a pull request to add @Markus43! 🎉 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The folders android, ios, linux, windows and macos aren't always available after flutter create for plugins. Check if they exist before cleaning them up. This is to avoid runtime errors when trying to change into non-existing folders.
Changes
Fixes #2208
Checklist
./frb_internal precommit --mode slow(orfast) is run (it internal runs code generator, does auto formatting, etc)../websitefolder) are updated.