Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log crate feature enabled by default #2245

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Make log crate feature enabled by default #2245

merged 3 commits into from
Aug 15, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Aug 15, 2024

Changes

Close #2243

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (4beab7f) to head (a54c0dd).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
- Coverage   99.06%   99.05%   -0.01%     
==========================================
  Files         488      488              
  Lines       20184    20195      +11     
==========================================
+ Hits        19995    20005      +10     
- Misses        189      190       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 191c9c9 into master Aug 15, 2024
137 checks passed
@fzyzcjy fzyzcjy deleted the feat/2243 branch August 15, 2024 01:47
@aran
Copy link
Contributor

aran commented Aug 20, 2024

Is this kind of a breaking change for users who set up their own logging according to the previous instructions?

e.g. prior to this change, users not using the 'log' feature can be calling log::set_logger.
Now that is called automatically, so it gets called twice and errors result.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Aug 20, 2024

@aran Hmm, I do not expect this to be a breaking change, but looks like yes, and I will consider more carefully next time :( But this also looks like a bugfix: the semantics and doc says frb setup logging automatically, so we should do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs not showing no matter the macro invocation
2 participants