Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint.singleEntryUrl must be "uri-template" not "uri" #103

Closed
redmitry opened this issue Jul 20, 2023 · 4 comments
Closed

Endpoint.singleEntryUrl must be "uri-template" not "uri" #103

redmitry opened this issue Jul 20, 2023 · 4 comments
Assignees
Milestone

Comments

@redmitry
Copy link
Collaborator

Hello,

In the beaconMapResponse (/map) there are some endpoint URLs that are defined as "format": "uri" while what is actually put / expected "format": "uri-template".
For instance, Endpoint.singleEntryUrl expects the entry identifier. Also additional endpoints should be correctedRealatedEndpoint.url .

Currently strict Json Schema Validator reports errors on all endpoints that have path parameters {}.

Cheers,

Dmitry

@costero-e
Copy link
Collaborator

For the endpoints that include parameters that must be resolved, like individuals/{id) it should be uri-template if we are accurate, yes.

Best,

Oriol

@jrambla
Copy link
Contributor

jrambla commented Sep 12, 2024

@redmitry should we consider this a breaking change or just a bug correction?

@redmitry
Copy link
Collaborator Author

Not critical bug correction.
Draft 7 validators should fail validating "singleEntryUrl": "https://beacons.bsc.es/beacon/v2.0.0/datasets/{id}" because "{}" characters forbidden in URI.
On the other hand in 2020-12 "format" property shouldn't be considered by default (should be ignored).
The question whether we want to enable "format" validation in 2020-12 and if validator used in beacon validator.

  1. may be programmatically configured to enable "format" vaildation.
  2. understand "vocabulary" way to enable "format" validation via JSON schema mechanism.

D.

@costero-e costero-e added this to the 2.1.1 milestone Oct 8, 2024
@costero-e
Copy link
Collaborator

Closing as this has been merged in #110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants