-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for templates the format must be "uri-template". #110
Conversation
IMU not all the uri you have modified are uri-templates (e.g. filteringterms). |
I would say uri-template is more like a type of uri, not the other way round. If we say something is a uri-template we are excluding uri that don't include braces {} with a parameter. |
https://datatracker.ietf.org/doc/html/rfc6570 uri-template is an URI "with variables" - it is as in the name - a template to produce the URI. Another thing is that Json Schemas 2019-2020 by default should just ignore "format". My validator validates it and reports an error. Current Beacon Network uses "fixed" schema (not from github) for the /map: So could we use "uri-template" in all places? Yes. But I see no point. Best, Dmitry |
Thank you @redmitry . So, are we still willing to accept this PR? Or can we close it? |
IMO this should be in the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If uri-template is a valid uri even if it doesn't carry variables within braces, this can be accepted from my side.
in the beaconMapSchema.json some URLs are templates and must have the uri-template" format (#103).