-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
received filters in summary to object #107
base: develop
Are you sure you want to change the base?
Conversation
As per our discussion I'm +1 on this. However, branch management => into Note to @redmitry: You also restructure the |
(postpone for another commit)
@redmitry Why is the "id" inside brackets array? Is it because the term can apply to different scopes so you have to define it for each of the scope differently? |
Do not get it. The only "id" inside brackets is in "required"
e.g.
D. |
Hey @redmitry, I meant in the examples: "examples": [ "demographic.ethnicity:asian" ], This would be passed as an "id" in the request but here you are specifying it has to be inside an array? Edit: Ah, now I see is type: "string", I said nothing, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the base branch to "develop". The rest seems fine so this is approved on my side.
I understand your point, @redmitry . However the difference between request and summary is there on purpose (not a strong purpose, I must say, anyway). |
There is an incoherence formats of filters submitted to the query and reported to be submitted:
"request summary" vs "submitted".
This pull request is to use the same filteringTerms format (object) in the beaconReceivedRequestSummary.
N.B. This would change 2.0 spec.
D.