Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong "runs", "analyses" entry types in beaconMap #126

Closed
wants to merge 2 commits into from
Closed

fix wrong "runs", "analyses" entry types in beaconMap #126

wants to merge 2 commits into from

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented Apr 15, 2024

See #125

costero-e
costero-e approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@costero-e costero-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we had it correctly spelled for some endpointSets like analysis or biosample but then the others were wrong. Thank you for spotting this @mbaudis. Read both files and seem correct now.

@costero-e
Copy link
Collaborator

Closing this as work has been done in another branch due to colliding files with same names (case insensitive).

@costero-e costero-e closed this Jul 10, 2024
@costero-e costero-e mentioned this pull request Jul 10, 2024
Merged
@costero-e costero-e deleted the hotfix-beaconMap-run-analysis branch July 16, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redmitry redmitry redmitry approved these changes

@costero-e costero-e costero-e approved these changes

@jrambla jrambla Awaiting requested review from jrambla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbaudis @costero-e @redmitry