Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid syntax in examples #140 #145

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

datsirul
Copy link
Contributor

This PR addresses the invalid syntax in the examples parameter. It makes the model endpoints files valid OpenAPI documents.
For more info see issue #140.

@costero-e costero-e changed the base branch from main to schema-urgent-fixes July 16, 2024 07:58
@jrambla jrambla self-requested a review July 22, 2024 19:03
Copy link
Contributor

@jrambla jrambla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any example with more than 1 value, as we had in the previous version.
Is that still possible with the "naming examples" approach?

@mbaudis
Copy link
Member

mbaudis commented Jul 22, 2024

... and maybe using descriptive names? I'm 60/40 on this ¯\_(ツ)_/¯

@datsirul
Copy link
Contributor Author

Sure, I think naming the examples would be the better approach and even provide better experiences in response mocking scenarios.
What would be the best approach to name these? Can anyone provide names, or is there a good way for me to look up these values?

@jrambla
Copy link
Contributor

jrambla commented Sep 12, 2024

@datsirul are you waiting for feedback on your last comment, right?

@jrambla
Copy link
Contributor

jrambla commented Oct 8, 2024

@datsirul ??

@jrambla jrambla added this to the 2.2.0 milestone Oct 8, 2024
@costero-e costero-e merged commit 39f4242 into ga4gh-beacon:schema-urgent-fixes Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants